[Explore] overriding Annotations and Layers' control tab #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
gabe_special_casing_annotation_tab
branch
from
0404b9b
to
95ffeea
Compare
|
thanks for updating this 🙌 LGTM, only possible suggestion would be making |
Codecov Report
@@ Coverage Diff @@
## master #4609 +/- ##
==========================================
- Coverage 71.19% 71.19% -0.01%
==========================================
Files 189 189
Lines 14840 14843 +3
Branches 1086 1088 +2
==========================================
+ Hits 10566 10568 +2
- Misses 4271 4272 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
LGTM |
|
Wouldn't be against them having their own tab, though that might be a bit much |
|
@williaster for simplicity lets keep it as is, if this annotations needs to be used elsewhere I agree we should clean it up. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as reported by @williaster- the annotations and layers control should live in the Data tab and not the Style tab, despite its renderTrigger value. Added this override in.
test plan:
Reviewers:
@michellethomas
@williaster
@graceguo-supercat
cc
@mistercrunch