Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[landing] Making Dashboards the first/default tab #4553

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Mar 7, 2018

@hughhhh I think that the "Recently Viewed" tab still needs some refinement in terms of what we show there, and that user's may be somewhat confused, i.e.,

screen shot 2018-03-06 at 5 35 12 pm

This PR changes the tab ordering and makes the "Dashboards" tab the first (and thus default) tab, which should seem more useful and familiar to users,

screen shot 2018-03-06 at 5 34 55 pm

to: @hughhhh @mistercrunch

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #4553 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4553   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         187      187           
  Lines       14780    14780           
  Branches     1083     1083           
=======================================
  Hits        10513    10513           
  Misses       4264     4264           
  Partials        3        3
Impacted Files Coverage Δ
superset/assets/javascripts/welcome/App.jsx 94.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e780e4...09b65bf. Read the comment docs.

@mistercrunch mistercrunch merged commit 01e0a2f into apache:master Mar 7, 2018
@john-bodley john-bodley deleted the john-bodley-landing-page-dashboards-default-tab branch March 7, 2018 03:59
john-bodley added a commit to john-bodley/superset that referenced this pull request Mar 7, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants