Return __time in Druid scan #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
reviewed
Mar 1, 2018
superset/viz.py
Outdated
| @@ -2040,7 +2040,7 @@ def get_properties(self, d): | |||
| 'radius': self.fixed_value if self.fixed_value else d.get(self.metric), | |||
| 'cat_color': d.get(self.dim) if self.dim else None, | |||
| 'position': d.get('spatial'), | |||
| '__timestamp': d.get('__timestamp'), | |||
| '__timestamp': d.get('__timestamp') or d.get('__time'), | |||
There was a problem hiding this comment.
There's a constant in scope that you can use: DTTM_ALIAS : d.get(DTTM_ALIAS) or d.get('__time'),
There was a problem hiding this comment.
We could introduce a DRUID_DTTM_ALIAS constant but may be out of scope for this PR
Codecov Report
@@ Coverage Diff @@
## master #4504 +/- ##
=========================================
Coverage ? 71.12%
=========================================
Files ? 187
Lines ? 14781
Branches ? 1083
=========================================
Hits ? 10513
Misses ? 4265
Partials ? 3
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Mar 13, 2018
* Return __time in Druid scan * use constant instead of __timestamp * Fix lint (cherry picked from commit 1647004)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 14, 2018
* Return __time in Druid scan * use constant instead of __timestamp * Fix lint (cherry picked from commit 1647004)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
* Cherry pick apache#4581 * Add flask-compress cherry * Add shortner fix * Add Return __time in Druid scan apache#4504 * Picking cherry Fixing regression from apache#4500 (apache#4549) * [bugfix] SQL Lab 'MySQL has gone away' It appears the 'MySQL has gone away' is triggered by the line of code I wrapped in a try block here. This is a temporary fix, there will be another PR shortly getting to the bottom of this. Related: https://github.com/lyft/druidstream/issues/40
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Return __time in Druid scan * use constant instead of __timestamp * Fix lint
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Return __time in Druid scan * use constant instead of __timestamp * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a scan in Druid we're not returning the temporal column
__time, which is needed for the play slider.I also fixed the status URL, which is broken in master.