Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the console has queried the released lock #5266

Conversation

renliangyu857
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5265

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 1, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Feb 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #5266 (680ecc2) into develop (851ed6d) will decrease coverage by 0.37%.
The diff coverage is 36.07%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5266      +/-   ##
=============================================
- Coverage      48.77%   48.41%   -0.37%     
- Complexity      4163     4169       +6     
=============================================
  Files            743      764      +21     
  Lines          26588    26894     +306     
  Branches        3320     3348      +28     
=============================================
+ Hits           12969    13020      +51     
- Misses         12220    12472     +252     
- Partials        1399     1402       +3     
Impacted Files Coverage Δ
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
.../src/main/java/io/seata/core/protocol/Version.java 7.50% <ø> (ø)
...gration/tx/api/annotation/AspectTransactional.java 58.49% <ø> (ø)
...annotation/BusinessActionContextParameterDesc.java 0.00% <0.00%> (ø)
...ta/integration/tx/api/event/DegradeCheckEvent.java 0.00% <ø> (ø)
...ration/tx/api/fence/DefaultCommonFenceHandler.java 0.00% <0.00%> (ø)
...gration/tx/api/fence/config/CommonFenceConfig.java 0.00% <0.00%> (ø)
...ion/tx/api/fence/constant/CommonFenceConstant.java 0.00% <0.00%> (ø)
...n/tx/api/fence/exception/CommonFenceException.java 0.00% <ø> (ø)
... and 78 more

@renliangyu857 renliangyu857 force-pushed the bugfix_console_has_queried_releasedlock branch from 680ecc2 to 82e025c Compare February 1, 2023 07:08
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit fb3d5c7 into apache:develop Feb 1, 2023
l81893521 pushed a commit to l81893521/seata that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console has queried the released lock
4 participants