-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: the console has queried the released lock #5266
bugfix: the console has queried the released lock #5266
Conversation
…sedlock' into bugfix_console_has_queried_releasedlock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5266 +/- ##
=============================================
- Coverage 48.77% 48.41% -0.37%
- Complexity 4163 4169 +6
=============================================
Files 743 764 +21
Lines 26588 26894 +306
Branches 3320 3348 +28
=============================================
+ Hits 12969 13020 +51
- Misses 12220 12472 +252
- Partials 1399 1402 +3
|
680ecc2
to
82e025c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5265
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews