-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: error image when use null value as image query condition in insert on duplicate #5031
bugfix: error image when use null value as image query condition in insert on duplicate #5031
Conversation
This pull request introduces 1 alert when merging 6128575 into e10e36c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## develop #5031 +/- ##
=============================================
- Coverage 49.42% 49.40% -0.02%
+ Complexity 4125 4124 -1
=============================================
Files 734 734
Lines 26054 26058 +4
Branches 3220 3221 +1
=============================================
- Hits 12877 12874 -3
- Misses 11803 11805 +2
- Partials 1374 1379 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要顺便把上述去重后多余的or去掉
其次https://github.com/seata/seata/pull/5028/files 依赖此pr,否者当存在uk且没有默认值是,会出现is "null"的条件导致sql报错
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''NULL' ) OR (test_id2 is 'NULL' ) FOR UPDATE' at line 1
…value_in_insertondup
1、问题
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问题记录: insert on duplicate 中存在从tablematedata读取唯一索引的时候没有判断是否需要加上转义符,假设这个所以是一个关键字,此时前镜像查询的sql会报错
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ecutor
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4956
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews