-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize the speed of buildLockKey #3700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3700 +/- ##
==========================================
Coverage 51.92% 51.93%
Complexity 3503 3503
==========================================
Files 639 639
Lines 21182 21184 +2
Branches 2634 2634
==========================================
+ Hits 10999 11001 +2
Misses 9089 9089
Partials 1094 1094
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
seata-go: apache/incubator-seata-go#696 |
Ⅰ. Describe what this PR did
// K为主键个数(getTableMeta().getPrimaryKeyOnlyName().size())
// M为字段数(getTableMeta().getAllColumns().size())
// N为行数(pksRows.size())
// 原复杂度
// N * M * K
// 优化后复杂度
// N * K
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews