feature: add volume cleanup behaviour and optimize setup defaults procedure #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptyin
force-pushed
the
feature/volumn-reclaim
branch
from
58eb3e8
to
e8070c6
Compare
slievrly
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
What this PR does?
This PR aims to provide users choices for retain or delete volumes after deleting CRs. Users can use following configurations to control this behaviour.
How so?
Basically, I added finalizers to CR for controllers to implement asynchronous pre-delete hooks. In this pre-delete hook, I cleanup all binded PVCs and orphaned PVCs as well.
See https://book.kubebuilder.io/reference/using-finalizers to learn the context.