Add staticcheck at CI #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wt-better
reviewed
Jan 29, 2024
| @@ -61,6 +61,9 @@ jobs: | |||
| - name: "run go build" | |||
| run: go build -v ./... | |||
|
|
|||
| - name: "Staticcheck" | |||
There was a problem hiding this comment.
use https://github.com/marketplace/actions/run-golangci-lint better?
golangci-lint is a fast Go linters aggregator that runs multiple linters and integrates the functionality of the previous Go Meta Linter. I understand it is currently the recommended tool.
There was a problem hiding this comment.
Somehow, nothing shows for golangci-lint. see https://github.com/smiletrl/incubator-seata-go/pull/1, https://github.com/smiletrl/incubator-seata-go/actions/runs/7697184584/job/20973667110?pr=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add staticcheck for Go code
A quick overview of current staticcheck result , result in great potential improvement room for this repository :)
Once we approve adding staticcheck for this repository, I can add fixes for staticcheck in this PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: