Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin #989

Closed
wants to merge 14 commits into from

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented May 31, 2022

What problem does this PR solve?

#988

What is changed and how does it work?

change java-client ci

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@acelyc111
Copy link
Member

acelyc111 commented May 31, 2022

Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234

.gitmodules Outdated Show resolved Hide resolved
@acelyc111
Copy link
Member

acelyc111 commented May 31, 2022

Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234

I've asked the ASF infra team to enable these actions, plz wait.
jira: https://issues.apache.org/jira/browse/INFRA-23313

@acelyc111
Copy link
Member

Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234

I've asked the ASF infra team to enable these actions, plz wait. jira: https://issues.apache.org/jira/browse/INFRA-23313

I’ve closed this issue, I'll reopen it after we decide to use which actions.

java-client/scripts/format-all.sh Outdated Show resolved Hide resolved
java-client/scripts/format-all.sh Outdated Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2 # v2 minimum required
- uses: axel-op/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give an example to show how it work?

foreverneverer
foreverneverer previously approved these changes Jun 1, 2022
@acelyc111 acelyc111 closed this Jun 1, 2022
@acelyc111 acelyc111 reopened this Jun 1, 2022
@acelyc111
Copy link
Member

Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234

I've asked the ASF infra team to enable these actions, plz wait. jira: https://issues.apache.org/jira/browse/INFRA-23313

I’ve closed this issue, I'll reopen it after we decide to use which actions.

new issue to track it https://issues.apache.org/jira/browse/INFRA-23327

@acelyc111 acelyc111 changed the title ci(java-client): GitHub action uses checkstyle to replace plugins for java-client code style checking during CI ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin Jun 1, 2022
@Apache9
Copy link
Contributor

Apache9 commented Jun 10, 2022

We just need to remove the spotless pluigin dependency from the dependencies section, we only need it in the plugins section.

Using another way to enforce format is another topic.

@acelyc111
Copy link
Member

Will be resolved by #1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants