-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(java-client): Use GitHub action to check and format Java code style instead of jar plugin #989
Conversation
Java client actions are not running normally, https://github.com/apache/incubator-pegasus/actions/runs/2412968234 |
I've asked the ASF infra team to enable these actions, plz wait. |
I’ve closed this issue, I'll reopen it after we decide to use which actions. |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 # v2 minimum required | ||
- uses: axel-op/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give an example to show how it work?
new issue to track it https://issues.apache.org/jira/browse/INFRA-23327 |
We just need to remove the spotless pluigin dependency from the dependencies section, we only need it in the plugins section. Using another way to enforce format is another topic. |
Will be resolved by #1000 |
What problem does this PR solve?
#988
What is changed and how does it work?
change java-client ci
Checklist
Tests
Code changes
Side effects
Related changes