Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge java client #964

Merged
merged 127 commits into from
May 9, 2022
Merged

Conversation

cauchy1988
Copy link
Contributor

What problem does this PR solve?

merge pegasus java client into incubator-pegasus

details can be seen in the issue : #945

What is changed and how does it work?

only add the java client repo

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

shengofsun and others added 30 commits March 10, 2018 11:29
Summary: Ref T9266

Test Plan: N/A

Reviewers: qinzuoyan, cailiuyang, heyuchen, wutao1, laiyingchun

Reviewed By: qinzuoyan

Subscribers: #pegasus

Maniphest Tasks: T9266

Differential Revision: https://phabricator.d.xiaomi.net/D86668
Summary: Ref T10114

Test Plan: N/A

Reviewers: qinzuoyan, cailiuyang

Reviewed By: qinzuoyan

Subscribers: #pegasus

Maniphest Tasks: T10114

Differential Revision: https://phabricator.d.xiaomi.net/D87645
…n obj

Summary: Ref T10114

Test Plan: N/A

Reviewers: qinzuoyan, cailiuyang

Reviewed By: qinzuoyan

Subscribers: #pegasus

Maniphest Tasks: T10114

Differential Revision: https://phabricator.d.xiaomi.net/D87746
…rection for multiGet

Summary: Ref T10566

Test Plan: N/A

Reviewers: sunweijie, cailiuyang

Reviewed By: sunweijie

Subscribers: #pegasus

Maniphest Tasks: T10566

Differential Revision: https://phabricator.d.xiaomi.net/D87870
Summary: Ref T10114

Test Plan: N/A

Reviewers: sunweijie, cailiuyang, laiyingchun

Reviewed By: laiyingchun

Subscribers: #pegasus

Maniphest Tasks: T10114

Differential Revision: https://phabricator.d.xiaomi.net/D88948
@cauchy1988 cauchy1988 changed the title Merge java client chore: Merge java client May 7, 2022
@cauchy1988 cauchy1988 force-pushed the merge-java-client branch 4 times, most recently from 6c421ee to c2ded94 Compare May 7, 2022 12:23
@acelyc111
Copy link
Member

acelyc111 commented May 9, 2022

I checked the following changes:

  • All files missing APLv2 license header have been added.
  • Package com.xiaomi.infra.pegasus has been rename to org.apache.pegasus

@acelyc111
Copy link
Member

acelyc111 commented May 9, 2022

Java client link in README.md should be updated.

@acelyc111
Copy link
Member

Unit test action [1] should also be migrated to this repo.

[1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml

@cauchy1988
Copy link
Contributor Author

Unit test action [1] should also be migrated to this repo.

[1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml

i have already added, it just be renamed to a new file ”test_java-client.yml“

java-client/README.md Outdated Show resolved Hide resolved
@acelyc111
Copy link
Member

Unit test action [1] should also be migrated to this repo.
[1] https://github.com/XiaoMi/pegasus-java-client/blob/master/.github/workflows/ci-pr.yaml

i have already added, it just be renamed to a new file ”test_java-client.yml“

OK, I saw it.

@cauchy1988 cauchy1988 force-pushed the merge-java-client branch from c2ded94 to 418d620 Compare May 9, 2022 04:13
java-client/README.md Outdated Show resolved Hide resolved
@cauchy1988 cauchy1988 force-pushed the merge-java-client branch from 418d620 to 6f2848c Compare May 9, 2022 04:24
acelyc111
acelyc111 previously approved these changes May 9, 2022
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acelyc111 acelyc111 merged commit fbed9a1 into apache:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants