Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'BATCH_GET' interface for read optimization #897

Merged
merged 18 commits into from
Feb 16, 2022
Merged

feat: add 'BATCH_GET' interface for read optimization #897

merged 18 commits into from
Feb 16, 2022

Conversation

cauchy1988
Copy link
Contributor

What problem does this PR solve?

all descriptions can be seen in the issue : #884

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@cauchy1988 cauchy1988 changed the title add 'BATCH_GET' interface for read optimization feat: add 'BATCH_GET' interface for read optimization Jan 28, 2022
acelyc111
acelyc111 previously approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This feature has been merged in our internal repo, and running well as expected in product env. Apprecite some other help to review, thanks!

foreverneverer
foreverneverer reviewed Feb 8, 2022
View reviewed changes
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.h Outdated Show resolved Hide resolved
src/server/capacity_unit_calculator.cpp Outdated Show resolved Hide resolved
@hycdong hycdong added the type/perf-counter PR that made modification on perf-counter, which should be noted in release note. label Feb 9, 2022
@acelyc111 acelyc111 added component/api pegasus client interfaces release-note Notes on the version release labels Feb 9, 2022
acelyc111
acelyc111 reviewed Feb 14, 2022
View reviewed changes
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
@cauchy1988 cauchy1988 requested a review from acelyc111 February 14, 2022 07:48
@cauchy1988 cauchy1988 requested a review from acelyc111 February 14, 2022 09:53
@levy5307 levy5307 merged commit dc4c710 into apache:master Feb 16, 2022
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@levy5307
refactor: move get_ddd_partitions from server_load_balancer to partit…
a33c9c9 
…ion_guardian (#897)
@foreverneverer foreverneverer mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@foreverneverer foreverneverer foreverneverer approved these changes

@levy5307 levy5307 Awaiting requested review from levy5307

Assignees
No one assigned
Labels
component/api pegasus client interfaces release-note Notes on the version release type/perf-counter PR that made modification on perf-counter, which should be noted in release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cauchy1988 @acelyc111 @levy5307 @foreverneverer @hycdong