Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): support to build on MacOS #891

Merged
merged 5 commits into from
Jan 27, 2022
Merged

feat(build): support to build on MacOS #891

merged 5 commits into from
Jan 27, 2022

Conversation

acelyc111
Copy link
Member

ref issue: #813

@acelyc111 acelyc111 mentioned this pull request Jan 23, 2022
Closed
@Smityz
Copy link
Contributor

Smityz commented Jan 25, 2022

Great job, after this PR merged, could you update the document on this page?
https://pegasus.apache.org/docs/build/compile-from-source/

@Smityz
Copy link
Contributor

Smityz commented Jan 25, 2022

Is it possible to add CI step for MACOS?

@acelyc111
Copy link
Member Author

Is it possible to add CI step for MACOS?

We can do it in the next step, similar to how rocksdb do, https://github.com/facebook/rocksdb/blob/7711f8cbb42dd96111a133099b029b6fabff6f48/.circleci/config.yml#L167

@acelyc111 acelyc111 merged commit a42ae44 into apache:master Jan 27, 2022
@hycdong hycdong mentioned this pull request Jan 29, 2022
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@hycdong
feat(split): add split reject counters (#891)
6135e45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foreverneverer foreverneverer foreverneverer approved these changes

@levy5307 levy5307 levy5307 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acelyc111 @Smityz @levy5307 @foreverneverer