feat(online_migration): part3 - support ingestion_behind for pegasus #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Jan 5, 2022
levy5307
reviewed
Jan 5, 2022
src/server/rocksdb_wrapper.cpp
Outdated
| @@ -180,9 +180,12 @@ int rocksdb_wrapper::write_batch_delete(int64_t decree, dsn::string_view raw_key | |||
|
|
|||
| void rocksdb_wrapper::clear_up_write_batch() { _write_batch->Clear(); } | |||
|
|
|||
| int rocksdb_wrapper::ingestion_files(int64_t decree, const std::vector<std::string> &sst_file_list) | |||
| int rocksdb_wrapper::ingestion_files(int64_t decree, | |||
There was a problem hiding this comment.
What about name it ingest_files?
levy5307
reviewed
Jan 5, 2022
src/server/pegasus_server_impl.cpp
Outdated
| { | ||
| const auto &iter = envs.find(ROCKSDB_ALLOW_INGEST_BEHIND); | ||
| if (iter == envs.end()) { | ||
| _allow_ingest_behind = false; |
There was a problem hiding this comment.
I think you can set _db_opts.allow_ingest_behind directly
Smityz
previously approved these changes
Jan 5, 2022
levy5307
reviewed
Jan 5, 2022
levy5307
approved these changes
Jan 6, 2022
Smityz
approved these changes
Jan 6, 2022
hycdong
added a commit
to hycdong/pegasus
that referenced
this pull request
Jan 29, 2022
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
…ad of dassert for duplication (#862)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #851 show, we decide to support online migration.
This pull request support it for pegasus, including:
allow_ingest_behindfrom app->envs, and set rocksdballow_ingest_behind, reference functionstartand functionupdate_allow_ingest_behind.ingest_behindfor ingestion, referenceingest_filesfunctions.ingest_behind