feat: add a function test for read/write throttling #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Nov 24, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
levy5307
reviewed
Nov 25, 2021
|
|
||
| if (test_plan.ot == operation_type::set) { | ||
| ref_count++; | ||
| pg_client->async_set( |
There was a problem hiding this comment.
I think you can encapsulate different operations into several small functions
There was a problem hiding this comment.
It's difficult to capture all the related parameters like throttle_test_recorder is_running ref_count
| result += chars[dsn::rand::next_u32(chars.size())]; | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
consider add the function into dsn::rand as common function
There was a problem hiding this comment.
I will do it in the next PR
foreverneverer
approved these changes
Dec 6, 2021
levy5307
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a function test for throttle