Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(split): add table level split reject counters #804

Merged
merged 3 commits into from
Aug 30, 2021
Merged

feat(split): add table level split reject counters #804

merged 3 commits into from
Aug 30, 2021

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Aug 30, 2021 •
edited
Loading

What problem does this PR solve?

This pull requests add the table-level rejecting read/write requests count during partition split.

collector*app.pegasus*app.stat.recent_write_splitting_reject_count#[table_name] - NUMBER
collector*app.pegasus*app.stat.recent_read_splitting_reject_count#[table_name]  - NUMBER
Tests

Tests in onebox

@hycdong hycdong marked this pull request as ready for review August 30, 2021 09:08
@hycdong hycdong added component/split partition split type/perf-counter PR that made modification on perf-counter, which should be noted in release note. labels Aug 30, 2021
@levy5307 levy5307 merged commit 6f339fa into apache:master Aug 30, 2021
foreverneverer
foreverneverer approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@foreverneverer foreverneverer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but the counter can be generated by scripts, you seem not use it

@hycdong hycdong deleted the add_split_reject_counter branch August 30, 2021 10:13
@hycdong hycdong mentioned this pull request Aug 31, 2021
Closed
@hycdong hycdong mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foreverneverer foreverneverer foreverneverer approved these changes

@Smityz Smityz Smityz approved these changes

@levy5307 levy5307 levy5307 approved these changes

Assignees
No one assigned
Labels
component/split partition split type/perf-counter PR that made modification on perf-counter, which should be noted in release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hycdong @levy5307 @Smityz @foreverneverer