-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split read request thread pool #782
Conversation
@Smityz What's your motivation to do this work? |
Slow query tasks like |
Imo separation of different types of operations into multiple pools doesn't essentially solve the problem... It only mitigates some cases... Think of a complex workload that consists of huge single key get, and small span of multiget. How do y suppose to adjust the thread pools? Will you assign a set of threads separately for each operation? |
Yeah, right. Actually we have discussed the problem for different case. However, since the benchmark has showed the improvement, at least it doesn't become worse, we decide apply it and verify its online effect.
|
…into split-proc-formal
Split read request into 2 threads pools.
get
andttl
use one threads pool, and other read requests use another oneRelated PR: XiaoMi/rdsn#856
Benchmark: benchmark.pdf