Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hotspot): add a cluster level perf_counter to display hotspot #732

Merged
merged 11 commits into from
May 28, 2021
Merged

feat(hotspot): add a cluster level perf_counter to display hotspot #732

merged 11 commits into from
May 28, 2021

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented May 20, 2021 •
edited
Loading

This PR adds a new perf_counter to show the count of hotspots in one table, it can help us intuitively find the hotspot in the cluster.

[collector*app.pegasus*app.stat.hotspots.temp.write.total, NUMBER, 2.00]

this perf_counter means in app temp has a hotspot in 2 partition

tangyanzhao added 2 commits May 21, 2021 11:07
@hycdong hycdong added the type/perf-counter PR that made modification on perf-counter, which should be noted in release note. label May 24, 2021
acelyc111
acelyc111 approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hycdong hycdong merged commit 14c87d9 into apache:master May 28, 2021
@hycdong hycdong mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 left review comments

@foreverneverer foreverneverer foreverneverer approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
type/perf-counter PR that made modification on perf-counter, which should be noted in release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Smityz @acelyc111 @levy5307 @foreverneverer @hycdong