feat: add base classes for user-specified compaction #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to add a proposal for this feature, even a Chinese doc. |
acelyc111
reviewed
May 22, 2021
|
I agree with @acelyc111 , expecting your proposal and detailed descriptions and comments. |
hycdong
approved these changes
May 28, 2021
| virtual ~compaction_filter_rule() = default; | ||
|
|
||
| // TODO(zhaoliwei): we can use `value_filed` to replace existing_value in the later, | ||
| // after the refactor of value schema |
There was a problem hiding this comment.
The refactor of value schema has already been merged, you can update it in next pull request :-)
There was a problem hiding this comment.
Yes, I will refactor it in the later
acelyc111
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
RFC: #738
Add base classes for user-specified compaction.
compaction_operationrepresents the compaction operation, such as update ttl/delete keycompaction_filter_rulerepresents the compaction rule to filter the keys which are stored in rocksdb.Checklist
Tests