feat(test): add one-time backup function tests #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
previously approved these changes
Apr 26, 2021
levy5307
reviewed
Apr 26, 2021
| const std::string _new_app_name; | ||
| const std::string _provider; | ||
|
|
||
| std::string _pegasus_root_dir; |
There was a problem hiding this comment.
dsn::string_view _pegasus_root_dir;
There was a problem hiding this comment.
global_env::instance()._pegasus_root returns string, so maybe no need to convert it to dsn::string_view.
hycdong
approved these changes
Apr 27, 2021
neverchanje
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add one-time backup function tests.
Checklist
Tests
local_serviceCode changes