Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shell app_stat removes unexpected columns #716

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix: shell app_stat removes unexpected columns #716

merged 1 commit into from
Apr 7, 2021

Conversation

neverchanje
Copy link
Contributor

What problem does this PR solve? 

>>> app_stat
F2021-04-07 16:11:32.546 (1617783092546521940 16004)  mimic.io-thrd.16004: output_utils.cpp:150:append_string_data(): assertion expression: last_index <= _max_col_width.size()
F2021-04-07 16:11:32.546 (1617783092546549469 16004)  mimic.io-thrd.16004: output_utils.cpp:150:append_string_data(): column data exceed

#705 This PR appends two columns to app_stat. But they don't have a column title. So when they are appended, the shell coredumped.

What is changed and how does it work?

This PR removes the incorrect two columns.

Checklist

Tests
  • Manual test (add detailed scripts or steps below)

Manually call app_stat, everything works.

@neverchanje neverchanje requested a review from levy5307 April 7, 2021 08:23
@neverchanje neverchanje merged commit 42f78aa into apache:master Apr 7, 2021
@neverchanje neverchanje deleted the shell branch April 7, 2021 09:33
neverchanje pushed a commit that referenced this pull request Apr 7, 2021
@neverchanje
fix: shell app_stat removes unexpected columns (#716)
579d6a9
zhangyifan27 pushed a commit to zhangyifan27/pegasus that referenced this pull request Jun 1, 2021
@zhangyifan27
fix: shell app_stat removes unexpected columns (apache#716)
93a7564
@hycdong hycdong mentioned this pull request Jun 8, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@zhangyifan27
BREAKING CHANGE(backup): remove 'policy_name' from backup files' path (…
bcc0e6a 
…#716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@hycdong hycdong hycdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverchanje @hycdong @levy5307