-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(split): scan support validate_partition_hash #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Mar 24, 2021
levy5307
reviewed
Mar 24, 2021
levy5307
reviewed
Mar 24, 2021
levy5307
approved these changes
Mar 29, 2021
acelyc111
approved these changes
Mar 31, 2021
zhangyifan27
pushed a commit
to zhangyifan27/pegasus
that referenced
this pull request
Jun 1, 2021
Closed
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supports validate partition_hash while scan, including c++ client and server implementation.
when scan_context.validate_partition_hash = true and app env validate_partition_hash = true, each iterator of scan will check partition_hash to avoid return stale data after partition split. If request.validate_partition_hash is not set, scan_context.validate_partition_hash = true, it is compatibility for old client. Besides, only full_scan need validate hash, hash_scan will not return stale data.
The result of different client and server will like: