Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete unused config aio_factory_name #699

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Mar 17, 2021

What problem does this PR solve?

In rdsn(XiaoMi/rdsn#778), we decoupled aio from dsn runtime. And make the config aio_factory_name unused. So in this pr, I remove the unused config aio_factory_name in each *.ini file

-  aio_factory_name

Check List

Tests

  • No code

@levy5307 levy5307 added the type/config-change Added or modified configuration that should be noted on release note of new version. label Mar 17, 2021
hycdong
hycdong previously approved these changes Mar 17, 2021
neverchanje
neverchanje previously approved these changes Mar 17, 2021
@levy5307 levy5307 dismissed stale reviews from neverchanje and hycdong via 8c70eb2 March 18, 2021 03:11
@hycdong hycdong merged commit 78fbd2e into apache:master Mar 18, 2021
@levy5307 levy5307 deleted the delete-factory-name branch March 18, 2021 06:50
@hycdong hycdong mentioned this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants