Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(split): gc useless data after partition split #698

Merged
merged 6 commits into from
Mar 23, 2021

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Mar 12, 2021

If app's validate_partition_hash=true, it will check partition_hash when execute rocksdb compaction, to gc old data during partition split.

@hycdong hycdong marked this pull request as ready for review March 22, 2021 01:55
@hycdong hycdong closed this Mar 22, 2021
@hycdong hycdong reopened this Mar 22, 2021
@hycdong hycdong added the component/split partition split label Mar 22, 2021
acelyc111
acelyc111 previously approved these changes Mar 22, 2021
src/server/key_ttl_compaction_filter.h Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Show resolved Hide resolved
src/base/pegasus_const.h Show resolved Hide resolved
@acelyc111 acelyc111 merged commit adcc62b into apache:master Mar 23, 2021
@hycdong hycdong deleted the ttl_filter branch March 23, 2021 02:01
@hycdong hycdong mentioned this pull request Sep 23, 2021
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/split partition split
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants