feat(hotkey): dynamic change some parameters in hotkey detection #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
previously approved these changes
Jan 11, 2021
levy5307
previously approved these changes
Jan 11, 2021
neverchanje
previously approved these changes
Jan 11, 2021
acelyc111
reviewed
Jan 11, 2021
|
How about add validator for the configuration which is necessary to validate? |
added 2 commits
January 11, 2021 14:49
Smityz
dismissed stale reviews from neverchanje, levy5307, and foreverneverer
via
56b475d
acelyc111
previously approved these changes
Jan 12, 2021
levy5307
previously approved these changes
Jan 12, 2021
levy5307
reviewed
Jan 12, 2021
src/server/hotkey_collector.cpp
Outdated
| @@ -33,12 +33,18 @@ DSN_DEFINE_uint32( | |||
| hot_bucket_variance_threshold, | |||
| 7, | |||
| "the variance threshold to detect hot bucket during coarse analysis of hotkey detection"); | |||
| DSN_TAG_VARIABLE(hot_bucket_variance_threshold, FT_MUTABLE); | |||
| DSN_DEFINE_validator(hot_bucket_variance_threshold, | |||
There was a problem hiding this comment.
uint32 must be >= 0, I think it's useless to add a validator here.
levy5307
reviewed
Jan 12, 2021
| @@ -41,17 +41,24 @@ DSN_DEFINE_bool("pegasus.collector", | |||
| enable_detect_hotkey, | |||
| false, | |||
| "auto detect hot key in the hot paritition"); | |||
| DSN_TAG_VARIABLE(enable_detect_hotkey, FT_MUTABLE); | |||
|
|
|||
| DSN_DEFINE_int32("pegasus.collector", | |||
There was a problem hiding this comment.
DSN_DEFINE_int32 -> DSN_DEFINE_uint32
levy5307
reviewed
Jan 12, 2021
|
|
||
| DSN_DEFINE_int32("pegasus.collector", | ||
| hot_partition_threshold, | ||
| 3, | ||
| "threshold of hotspot partition value, if app.stat.hotspots >= " | ||
| "FLAGS_hotpartition_threshold, this partition is a hot partition"); | ||
| DSN_TAG_VARIABLE(hot_partition_threshold, FT_MUTABLE); | ||
| DSN_DEFINE_validator(hot_partition_threshold, | ||
| [](int32_t threshold) -> bool { return threshold >= 0; }); | ||
|
|
||
| DSN_DEFINE_int32("pegasus.collector", |
There was a problem hiding this comment.
DSN_DEFINE_int32 -> DSN_DEFINE_uint32
Smityz
force-pushed
the
hotkey-mutable
branch
from
5c1b2ca to
0d5aa52
Compare
levy5307
approved these changes
Jan 12, 2021
hycdong
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.