Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(shell): delete the disk info query command #644

Merged
merged 2 commits into from
Nov 12, 2020
Merged

refactor(shell): delete the disk info query command #644

merged 2 commits into from
Nov 12, 2020

Conversation

foreverneverer
Copy link
Contributor

What problem does this PR solve?

disk_replica and disk_capacity command has compatibility with XiaoMi/rdsn#651, the command is deprecated and will be implemented

What is changed and how it works?

Delete disk_replica and disk_capacity command

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@foreverneverer foreverneverer merged commit 2a74a7c into apache:master Nov 12, 2020
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@hycdong
refactor: reduce netprovider unit test executing time (#644)
af60c5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@hycdong hycdong hycdong approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foreverneverer @neverchanje @hycdong @levy5307