fix(hotspot): replace partition_resolver to ddl_client #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Nov 11, 2020
levy5307
reviewed
Nov 11, 2020
hycdong
reviewed
Nov 11, 2020
| @@ -316,7 +316,8 @@ info_collector::get_hotspot_calculator(const std::string &app_name, const int pa | |||
| if (iter != _hotspot_calculator_store.end()) { | |||
| return iter->second; | |||
| } | |||
| auto calculator = std::make_shared<hotspot_partition_calculator>(app_name, partition_count); | |||
| auto calculator = | |||
| std::make_shared<hotspot_partition_calculator>(app_name, partition_count, _shell_context); | |||
There was a problem hiding this comment.
I think ddl_client is necessary for hotspot_partition_calculator, you can create a new ddl client instance for calculator, not share the shell_context with info_collector.
There was a problem hiding this comment.
There will be a lot of hotspot_partition_calculator(s) in one database, I think it is better to share one instance
| int partition_count; | ||
| std::vector<dsn::partition_configuration> partitions; | ||
| _shell_context->ddl_client->list_app(app_name, app_id, partition_count, partitions); | ||
| auto target_address = partitions[partition_index].primary; |
There was a problem hiding this comment.
It seems that you don't validate the partition_index, will the caller ensure that the partition_index is valid?
Co-authored-by: Yingchun Lai <[email protected]>
acelyc111
approved these changes
Nov 12, 2020
neverchanje
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
detect_hotkey_requestwas removed from rrdb_types,partition_resolverneeds to be replaced to send RPC correctly.