feat(hotkey): capture data part3 - declare fine collector #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Oct 28, 2020
levy5307
reviewed
Oct 28, 2020
added 2 commits
October 28, 2020 16:02
hycdong
reviewed
Oct 29, 2020
levy5307
reviewed
Nov 2, 2020
levy5307
reviewed
Nov 2, 2020
acelyc111
reviewed
Nov 2, 2020
src/server/hotkey_collector.cpp
Outdated
Comment on lines
301
to
315
| struct blob_hash | ||
| { | ||
| std::size_t operator()(const dsn::blob &str) const | ||
| { | ||
| dsn::string_view cp(str); | ||
| return boost::hash_range(cp.begin(), cp.end()); | ||
| } | ||
| }; | ||
| struct blob_equal | ||
| { | ||
| std::size_t operator()(const dsn::blob &lhs, const dsn::blob &rhs) const | ||
| { | ||
| return dsn::string_view(lhs) == dsn::string_view(rhs); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Better to move to class dsn::blob's definition, then you can reuse it easily.
There was a problem hiding this comment.
// blob.h
bool operator==(const blob &r) const
{
// not implemented
assert(false);
return false;
}The default method is deleted, I think in different scenarios == has different meanings
There was a problem hiding this comment.
How the == operator of a class can have different behaviors?
added 2 commits
November 4, 2020 11:25
levy5307
reviewed
Nov 4, 2020
levy5307
reviewed
Nov 4, 2020
levy5307
reviewed
Nov 4, 2020
levy5307
reviewed
Nov 4, 2020
levy5307
reviewed
Nov 4, 2020
acelyc111
reviewed
Nov 4, 2020
Co-authored-by: Yingchun Lai <[email protected]>
acelyc111
previously approved these changes
Nov 5, 2020
neverchanje
reviewed
Nov 5, 2020
neverchanje
reviewed
Nov 5, 2020
Co-authored-by: Wu Tao <[email protected]>
Co-authored-by: Wu Tao <[email protected]>
neverchanje
reviewed
Nov 5, 2020
Co-authored-by: Wu Tao <[email protected]>
Co-authored-by: Wu Tao <[email protected]>
hycdong
approved these changes
Nov 6, 2020
neverchanje
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the implement of fine collector
Config changes
[pegasus.server] + fine_data_variance_threshold = 3