feat(hotkey): collector can be terminated by timeout #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
added
the
type/config-change
acelyc111
reviewed
Oct 20, 2020
neverchanje
reviewed
Oct 20, 2020
neverchanje
previously approved these changes
Oct 20, 2020
levy5307
reviewed
Oct 20, 2020
acelyc111
reviewed
Oct 20, 2020
Co-authored-by: Yingchun Lai <[email protected]>
levy5307
reviewed
Oct 21, 2020
added 4 commits
October 21, 2020 12:13
levy5307
previously approved these changes
Oct 21, 2020
added 2 commits
October 21, 2020 17:02
acelyc111
reviewed
Oct 21, 2020
hycdong
reviewed
Oct 21, 2020
hycdong
approved these changes
Oct 22, 2020
acelyc111
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set config
hotkey_collector_max_work_timeto determine how long will the hotkey detection takes.If the running time is greater than the
hotkey_collector_max_work_time, the hotkey collection will be terminated automatically.Config changes
[pegasus.server] + max_seconds_to_detect_hotkey = 150