Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hotkey): capture data part1 - declare internal collector #618

Merged
merged 19 commits into from
Oct 16, 2020
Merged

feat(hotkey): capture data part1 - declare internal collector #618

merged 19 commits into from
Oct 16, 2020

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Oct 13, 2020 •
edited by neverchanje
Loading

According to the comments in hotkey_collector.h and #616
hotkey_coarse_data_collector is to capture and analyze data in the COARSE state
hotkey_fine_data_collector is to capture and analyze data in the FINE state

Config changes

[pegasus.collector]
+ hotkey_analyse_time_interval_s = 10

@Smityz Smityz changed the title feat(hotkey): add some internal variables in hotkey_collector feat(hotkey): capture data part1 - declare internal collector Oct 14, 2020
@Smityz Smityz force-pushed the hotkey-collector-define branch from b3c7e67 to af7117b Compare October 14, 2020 06:02
acelyc111
acelyc111 reviewed Oct 15, 2020
View reviewed changes
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
src/server/hotkey_collector.h Outdated Show resolved Hide resolved
src/server/hotkey_collector.cpp Outdated Show resolved Hide resolved
src/server/hotkey_collector.cpp Outdated Show resolved Hide resolved
@acelyc111 acelyc111 merged commit 1461dc5 into apache:master Oct 16, 2020
@acelyc111 acelyc111 added the type/config-change Added or modified configuration that should be noted on release note of new version. label Oct 20, 2020
@Smityz Smityz deleted the hotkey-collector-define branch October 20, 2020 09:23
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
@levy5307
feat(security): server_negotiation handle challenge response (#618)
4425703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 left review comments

@hycdong hycdong hycdong approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smityz @acelyc111 @hycdong @levy5307