feat(hotspot): add a function to start hotkey detecting in shell commands #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Sep 21, 2020
levy5307
reviewed
Sep 21, 2020
acelyc111
reviewed
Sep 21, 2020
hycdong
reviewed
Sep 22, 2020
Smityz
force-pushed
the
hotkey-shell
branch
from
38fc91e to
d16752e
Compare
levy5307
reviewed
Sep 23, 2020
levy5307
reviewed
Sep 23, 2020
hycdong
reviewed
Sep 23, 2020
acelyc111
reviewed
Sep 23, 2020
Smityz
force-pushed
the
hotkey-shell
branch
from
d4127e1 to
6054cfb
Compare
levy5307
reviewed
Sep 28, 2020
src/shell/command_helper.h
Outdated
| @@ -35,6 +35,7 @@ | |||
|
|
|||
| #include "command_executor.h" | |||
| #include "command_utils.h" | |||
| #include "validate_utils.h" | |||
There was a problem hiding this comment.
why did you add #include "validate_utils.h" here?
levy5307
reviewed
Sep 28, 2020
levy5307
reviewed
Sep 28, 2020
levy5307
reviewed
Sep 28, 2020
levy5307
reviewed
Sep 28, 2020
levy5307
reviewed
Sep 28, 2020
hycdong
reviewed
Sep 28, 2020
hycdong
reviewed
Sep 29, 2020
levy5307
reviewed
Sep 29, 2020
levy5307
reviewed
Sep 29, 2020
acelyc111
reviewed
Sep 29, 2020
Co-authored-by: Yingchun Lai <[email protected]>
Co-authored-by: Yingchun Lai <[email protected]>
Co-authored-by: Yingchun Lai <[email protected]>
acelyc111
approved these changes
Sep 29, 2020
levy5307
approved these changes
Sep 29, 2020
hycdong
approved these changes
Sep 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add a function to start and stop hotkey detecting in shell commands
Because of the file structure, it's difficult to reuse code in
hotspot_partition_calculator::send_hotkey_detect_request, so I reimplemented a code in client to send the RPC