fix: fix the bug in restore_test #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
previously approved these changes
Apr 13, 2020
|
If |
Done. |
neverchanje
approved these changes
Apr 14, 2020
hycdong
approved these changes
Apr 14, 2020
Closed
neverchanje
pushed a commit
that referenced
this pull request
Apr 15, 2020
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The restore_test will fail when we run function test now. This pr is used for fix this bug.
What is changed and how it works?
In our implement, backup interval must be greatger than
cold_backup_checkpoint_reserve_minutes, which is 10 minutes in default.And in restore_test, the backup interval is 1 seconds, while cold_backup_checkpoint_reserve_minutes is 10 minutes. So it will produces some error in running restore_test.
Check List
Related changes
yes