Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node qps sum inconsistent with app qps sum #511

Merged
merged 4 commits into from
Apr 9, 2020

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Apr 7, 2020

What problem does this PR solve?

In shell tools, we can use app_stat -q to show app's qps, and we also can use nodes -q to show nodes' qps. However, the results of two command are different. This pull request fix this bug and add cu in nodes -q command.

Qps counters are like replica*app.pegasus*[email protected], we should use perf-counters-by-prefix to filter app id and partition index, and accumulate them to get qps of specific node.

We record P99 and P999 latency, those counters are like zion*profiler*RPC_RRDB_RRDB_PUT.latency.server and zion*profiler*RPC_RRDB_RRDB_PUT.latency.server.p999, and latency value won't be accumulated.

As a result, I separate qps and latency in two query-commands, and display them in nodes -q.

Command example

nodes -q command example:

>>> nodes -q
[details]
address      status    get_qps  mget_qps  read_cu  put_qps  mput_qps  write_cu  get_p99(ms)  mget_p99(ms)  put_p99(ms)  mput_p99(ms)
ip1:host1    ALIVE        0.00      0.00     0.00  1014.91      0.00   3510.00         0.00          0.00       336.78          0.00
ip2:host2    ALIVE        0.00      0.00     0.00  1004.73      0.00   2675.00         0.00          0.00       344.20          0.00
ip3:host3    ALIVE        0.00      0.00     0.00   992.71      0.00   3815.00         0.00          0.00       231.92          0.00

[summary]
total_node_count    : 3
alive_node_count    : 3
unalive_node_count  : 0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

@neverchanje neverchanje added the type/bug-fix This PR fixes a bug. label Apr 7, 2020
@neverchanje neverchanje self-requested a review April 7, 2020 08:11
@acelyc111 acelyc111 merged commit 1a1fc19 into apache:master Apr 9, 2020
@neverchanje neverchanje mentioned this pull request Apr 10, 2020
@hycdong hycdong deleted the fix_qps branch June 3, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.12.3 type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants