fix: node qps sum inconsistent with app qps sum #511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In shell tools, we can use
app_stat -q
to show app's qps, and we also can usenodes -q
to show nodes' qps. However, the results of two command are different. This pull request fix this bug and add cu innodes -q
command.Qps counters are like
replica*app.pegasus*[email protected]
, we should useperf-counters-by-prefix
to filter app id and partition index, and accumulate them to get qps of specific node.We record P99 and P999 latency, those counters are like
zion*profiler*RPC_RRDB_RRDB_PUT.latency.server
andzion*profiler*RPC_RRDB_RRDB_PUT.latency.server.p999
, and latency value won't be accumulated.As a result, I separate qps and latency in two query-commands, and display them in
nodes -q
.Command example
nodes -q
command example:Check List
Tests