-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shell command for query_disk_info #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Mar 13, 2020
acelyc111
reviewed
Mar 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I query a node's replica distribution by add
-a
parameter, disk capacity details will disappear? - How can I query all nodes disk capacity details or replica distribution details, I have to query them one by one?
It's too puzzled, I suggest you to design the shell command well and we reach an agreement at first.
OK, Current design reaosns are:
|
levy5307
reviewed
Mar 23, 2020
levy5307
reviewed
Mar 23, 2020
levy5307
reviewed
Mar 23, 2020
levy5307
reviewed
Mar 23, 2020
acelyc111
previously approved these changes
Mar 23, 2020
neverchanje
reviewed
Mar 23, 2020
levy5307
reviewed
Mar 23, 2020
neverchanje
reviewed
Mar 23, 2020
neverchanje
reviewed
Mar 23, 2020
neverchanje
approved these changes
Mar 24, 2020
acelyc111
approved these changes
Mar 24, 2020
Closed
neverchanje
pushed a commit
that referenced
this pull request
Mar 31, 2020
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important things
The PR depends XiaoMi/rdsn#409 and XiaoMi/rdsn#416, it should not be merged until XiaoMi/rdsn#409 and XiaoMi/rdsn#416 are merged
What problem does this PR solve?
add shell command for query_disk_info. related pr: XiaoMi/rdsn#409
What is changed and how it works?
Check List
Tests
Use 127.0.0.1 instead of real node address.
test disk capacity info
test disk replica count info
test invalid arguments and err response (take disk_replica as example)
Related changes