fix: fix the invalid IP address in src/server/test/config.ini #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/server/test/config.ini
Outdated
| @@ -503,5 +503,5 @@ onebox = 1 | |||
| onebox2 = 2 | |||
|
|
|||
| [pegasus.clusters] | |||
| onebox = @LOCAL_IP@:34701,@LOCAL_IP@:34702,@LOCAL_IP@:34703 | |||
| onebox2 = @LOCAL_IP@:34701,@LOCAL_IP@:34702,@LOCAL_IP@:34703 | |||
| onebox = 0.0.0.0:34701,0.0.0.0:34702,0.0.0.0:34703 | |||
There was a problem hiding this comment.
先查为什么travis上LOCAL_IP不会被替换
levy5307
reviewed
Mar 3, 2020
src/server/test/config.ini
Outdated
| @@ -503,5 +503,5 @@ onebox = 1 | |||
| onebox2 = 2 | |||
|
|
|||
| [pegasus.clusters] | |||
| onebox = @LOCAL_IP@:34701,@LOCAL_IP@:34702,@LOCAL_IP@:34703 | |||
| onebox2 = @LOCAL_IP@:34701,@LOCAL_IP@:34702,@LOCAL_IP@:34703 | |||
| onebox = 0.0.0.0:34701,0.0.0.0:34702,0.0.0.0:34703 | |||
There was a problem hiding this comment.
这里用0.0.0.0的话，后面运行时会替换成本地ip地址吗？
src/server/test/run.sh
Outdated
| @@ -1,13 +1,57 @@ | |||
| #!/usr/bin/env bash | |||
src/server/test/run.sh
Outdated
| fi | ||
| } | ||
|
|
||
| LOCAL_IP=`get_local_ip` |
There was a problem hiding this comment.
没必要复制一遍get_local_ip
你可以给这个脚本提供一个选项，提供LOCAL_IP变量
或者更简单的，把LOCAL_IP替换放在根目录run.sh run_test()里，这个run.sh就检测下config.ini有没有被替换就行了。如果有人单独执行这个脚本，可以更早发现config.ini的问题
vagetablechicken
approved these changes
Mar 4, 2020
acelyc111
approved these changes
Mar 4, 2020
Closed
neverchanje
pushed a commit
that referenced
this pull request
Mar 31, 2020
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref XiaoMi/rdsn#413