-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix bug in del function of redis_proxy #489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
previously approved these changes
Mar 3, 2020
Can you include the manual test in the PR description? This PR does not show any kind of test for us. Like this: Previous version
Current version
|
I tried these commands on http://try.redis.io/. Deleting a non-existed key will return 0, but your version returns 1. This should be noted in our code.
|
neverchanje
reviewed
Mar 5, 2020
Co-Authored-By: Wu Tao <[email protected]>
neverchanje
previously approved these changes
Mar 5, 2020
acelyc111
approved these changes
Mar 5, 2020
neverchanje
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In redis_proxy,"OK" will be returned using del function to delete a key, If the function executes successfully. But interface definition of redis shows that it should return the number of keys which are deleted.
While, there are some difference between interface definition of redis and redis proxy of pegasus. Because whether the key is exist or not, pegasus will return "OK" to redis proxy, so we cann't distinguish whether the key is deleted or not. so in this case , we unity returns 1.
Redis documentation about del: https://redis.io/commands/del
What is changed and how it works?
Change the return value from "OK" to the number of keys.
Check List
Tests
1.start a redis proxy in c4tst-injection
2.clone redis code, and build it.
3.use command of ./redis_cli -h host -p port to connect with the redis proxy
4.insert a k-v pair into redis proxy:
6.del the key which was inserted before in current version. It returns 1, not "OK".
7.del a key which is not exist in current version. It returns 1, also.
Related changes