Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use db when it has been opened #481

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Feb 19, 2020

What problem does this PR solve?

  • It's a bug to call rocksdb::CancelAllBackgroundWork when close replica after db open failed
  • Explicitly delete db in pegasus_server_impl's destructor

What is changed and how it works?

No related.

Check List

Tests

  • Unit test
    No
  • Integration test
    No
  • Manual test (add detailed scripts or steps below)
    Yes
  • No code
    No

Code changes

  • Has exported function/method change
    No
  • Has exported variable/fields change
    No
  • Has interface methods change
    No
  • Has persistent data change
    No

Side effects

  • Possible performance regression
    No
  • Increased code complexity
    No
  • Breaking backward compatibility
    No

Related changes

  • Need to cherry-pick to the release branch
    Yes
  • Need to update the documentation
    No
  • Need to be included in the release note
    No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants