feat(split): add partition_version #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
hycdong
changed the title
acelyc111
reviewed
Feb 20, 2020
| @@ -340,6 +342,8 @@ class pegasus_server_impl : public ::dsn::apps::rrdb_service | |||
|
|
|||
| pegasus_manual_compact_service _manual_compact_svc; | |||
|
|
|||
| std::atomic<int32_t> _partition_version; | |||
There was a problem hiding this comment.
放到基类replication_app_base里面是不是更合理？毕竟pegasus_server_impl不应该知道partition这个概念
There was a problem hiding this comment.
pegasus_server_impl也需要partition_version这个变量，split会让parent拥有child的数据，child也拥有parent的数据，在split完成之后这些无效数据应该要被删除，partition_version就被用于这个无效数据的清理，后续pr会交这部分的代码
levy5307
reviewed
Feb 20, 2020
acelyc111
approved these changes
Feb 20, 2020
levy5307
approved these changes
Feb 20, 2020
Closed
neverchanje
pushed a commit
that referenced
this pull request
Mar 31, 2020
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add definition of
partition_version, used for partition split to guarantee data consistency.What is changed and how it works?
Check List
Tests
Related changes