Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce a new task code for replicas stat #2169

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Dec 13, 2024

Currently calculating stats for replicas is still controlled by a configuration of
gc_disabled and based on the task code of "garbage collect", which is already
the legacy for GC of shared logs. We could introduce individual controller and
task code for the replicas stats.

Configurations are changed as follows:

[replication]
+ replicas_stat_disabled = false
- gc_disabled = false

@github-actions github-actions bot added the cpp label Dec 13, 2024
@empiredan empiredan force-pushed the replicas-stat-task-code branch from c110e91 to 7a43354 Compare December 13, 2024 06:28
@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label Dec 13, 2024
@empiredan empiredan marked this pull request as ready for review December 16, 2024 04:56
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, but it's still some kind of breaking change, the config key has been changed, we should mention it and show it in release note.

@empiredan
Copy link
Contributor Author

Alright, but it's still some kind of breaking change, the config key has been changed, we should mention it and show it in release note.

Exactly, I'll mention it both in Behavior changes and Configuration Changes for the new release.

@empiredan empiredan merged commit a65d1f4 into apache:master Dec 17, 2024
93 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants