-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(duplication): improve dups
command to make the output info easier to understand
#2167
Conversation
dups
commanddups
command to make the output info easier to understand
@empiredan there is still an IWYU error. |
} | ||
for (const auto &[remote_cluster, cnt] : stat.dup_remote_cluster_stats) { | ||
printer.add_row_name_and_data(fmt::format("{}_count", remote_cluster), cnt); | ||
printer.add_row_name_and_data( | ||
fmt::format("duplication_count_by_follower_cluster({})", remote_cluster), cnt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the row names are too long, the displayed table row may be too wide and hard to be filled on screen ?
Could you please give a sampe output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it's key/value pair under a summary tag:
[summary]
total_app_count : 8
duplicating_app_count : 3
unfinished_app_count : 0
duplication_count : 3
DS_LOG_count : 3
target_cluster_count : 3
total_partition_count : 64
duplicating_partition_count : 24
unfinished_partition_count : 0
OK, previously it suggested to add:
And in #2166 |
Improvements for the command of listing duplications have been made in
the following aspects:
cluster to avoid misunderstanding.
DS_LOG
as the prerequisite for a duplication to be considered asfinished.
decree and last committed decree.