Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duplication): improve dups command to make the output info easier to understand #2167

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Dec 12, 2024

Improvements for the command of listing duplications have been made in
the following aspects:

  • change the description for the stats of duplication by status and follower
    cluster to avoid misunderstanding.
  • add DS_LOG as the prerequisite for a duplication to be considered as
    finished.
  • introduce a new partition-level column showing the gap between confirmed
    decree and last committed decree.
  • fix the options for json format and output file.

@github-actions github-actions bot added the cpp label Dec 12, 2024
@empiredan empiredan marked this pull request as ready for review December 12, 2024 15:51
@empiredan empiredan added component/duplication cluster duplication component/shell pegasus shell labels Dec 12, 2024
@empiredan empiredan changed the title feat(duplication): improve the display of dups command feat(duplication): improve dups command to make the output info easier to understand Dec 12, 2024
@acelyc111
Copy link
Member

@empiredan there is still an IWYU error.

}
for (const auto &[remote_cluster, cnt] : stat.dup_remote_cluster_stats) {
printer.add_row_name_and_data(fmt::format("{}_count", remote_cluster), cnt);
printer.add_row_name_and_data(
fmt::format("duplication_count_by_follower_cluster({})", remote_cluster), cnt);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the row names are too long, the displayed table row may be too wide and hard to be filled on screen ?

Could you please give a sampe output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's key/value pair under a summary tag:

[summary]
total_app_count              : 8
duplicating_app_count        : 3
unfinished_app_count         : 0
duplication_count            : 3
DS_LOG_count                 : 3
target_cluster_count         : 3
total_partition_count        : 64
duplicating_partition_count  : 24
unfinished_partition_count   : 0

@empiredan
Copy link
Contributor Author

empiredan commented Dec 13, 2024

@empiredan there is still an IWYU error.

OK, previously it suggested to add:

>>> Fixing #includes in '/__w/incubator-pegasus/incubator-pegasus/src/replica/replica_backup.cpp'
@@ -28,6 +28,7 @@
 #include <map>
 #include <memory>
 #include <string>
+#include <type_traits>
 #include <utility>
 #include <vector>

And in #2166 #include <type_traits> is also removed from src/replica/replica_backup.cpp.

@empiredan empiredan merged commit c2c070b into apache:master Dec 13, 2024
82 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/duplication cluster duplication component/shell pegasus shell cpp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants