fix(bulkload): bulkload cause many node coredump #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Jul 24, 2024
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
from
34cede1 to
fdd04eb
Compare
acelyc111
reviewed
Aug 7, 2024
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
from
710a155 to
5469727
Compare
…sst_file (apache#2006) replica_bulk_loader::clear_bulk_load_states function cannot cancel already downloading sst task, which access `_metadata.files` references. But clear_bulk_load_states function will clear `_metadata.files`. It's cause core dump. I use a copy of `_metadata.files` to solve this problem.
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
5 times, most recently
from
ac809ae to
99100fd
Compare
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
from
a7608ec to
020b105
Compare
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
from
b6d3ad2 to
40ae94b
Compare
ruojieranyishen
force-pushed
the
bulkload_coredump_fix
branch
from
40ae94b to
46d15af
Compare
acelyc111
reviewed
Sep 24, 2024
| fs)); | ||
| if (!download_file_metas.empty()) { | ||
| _download_files_task[download_file_metas.back().name] = tasking::enqueue( | ||
| LPC_BACKGROUND_BULK_LOAD, tracker(), [=, file_metas = download_file_metas]() mutable { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related issue:
#2006
What is changed and how does it work?
Avoid using _metadata.files reference ，and add a read_lock
Tests
Because bulkload imports a large amount of data.
Test 1: bulkload files miss four sst files.
After fix : Table ingest_p4_10G partition1 is missing files, and the table ballot does not increase after bulkload.
Test 2: Bulkload Download stage restart a node
After fix ： No continuous core dumps on multiple nodes.
Side effects
Locking
_metadata.filesmay incur a performance penalty.