feat(FQDN): Add host_port structures for clients and bump actions/checkout from v3 to v4 #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
bump_actions_checkout_v4
branch
from
9b5a6a4 to
61d0720
Compare
acelyc111
force-pushed
the
bump_actions_checkout_v4
branch
from
f32e7dd to
151d91b
Compare
acelyc111
force-pushed
the
bump_actions_checkout_v4
branch
from
151d91b to
cbdca43
Compare
acelyc111
changed the title
empiredan
approved these changes
Jul 12, 2024
foreverneverer
approved these changes
Jul 12, 2024
ruojieranyishen
pushed a commit
to ruojieranyishen/incubator-pegasus
that referenced
this pull request
Jul 17, 2024
…ckout from v3 to v4 (apache#2062) After All GitHub Actions run on Node20 instead of Node16 by default [1], this patch bumps the actions/checkout version from v3 to v4. When the related yaml files changed, the clients CIs are triggered, then they expose that the new introduced structure `host_port` in IDL as unknow because it is not generated by thrift automatically, we have to implement it manually. So this patch also simplily implements the `host_port` structure in python-client and nodejs-client. It should be mentioned that only the `build_debug_on_centos7` is still using `actions/checkout@v3`, see [2] for details. 1. https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ 2. apache#2065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After All GitHub Actions run on Node20 instead of Node16 by default [1],
this patch bumps the actions/checkout version from v3 to v4.
When the related yaml files changed, the clients CIs are triggered, then
they expose that the new introduced structure
host_portin IDL as unknowbecause it is not generated by thrift automatically, we have to implement
it manually. So this patch also simplily implements the
host_portstructure in python-client and nodejs-client.
It should be mentioned that only the
build_debug_on_centos7is still usingactions/checkout@v3, see [2] for details.