Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): Fill timestamp in log file name and limit single file size and total count #2024

Merged
merged 2 commits into from
May 27, 2024

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented May 24, 2024

  • A new symlink is added to point to the latest log file, the symlink is in
    the same directory as the log files.

Behavior change:

  • Log file is rolled by max_log_file_bytes configuration (64MB by default)
    instead of the fixed line count, i.e. 200000.
  • Log files are named as log.<yyyyMMdd_hhmmss_SSS>, e.g. log.20240524_1806_235
    instead of log.<index>.txt, e.g. log.123.txt
[tools.simple_logger]
+max_log_file_bytes =

@github-actions github-actions bot added the cpp label May 24, 2024
@acelyc111 acelyc111 changed the title feat(logging): Use timestamp instead of index in log files and limit file size and count feat(logging): Fill timestamp in log files and limit single file size and total count May 24, 2024
@acelyc111 acelyc111 marked this pull request as ready for review May 24, 2024 11:00
@acelyc111 acelyc111 changed the title feat(logging): Fill timestamp in log files and limit single file size and total count feat(logging): Fill timestamp in log file name and limit single file size and total count May 24, 2024
@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label May 27, 2024
@acelyc111 acelyc111 merged commit 80fcc79 into apache:master May 27, 2024
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants