Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logging): Minor refactor on logging module #2022

Merged
merged 1 commit into from
May 24, 2024
Merged

refactor(logging): Minor refactor on logging module #2022

merged 1 commit into from
May 24, 2024

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented May 23, 2024 •
edited
Loading

Mainly including:

  • Using fmt::format/print instead of sprintf/printf, which is more convenient
    and faster
  • Add some configuration validators
  • Encapsulate print_header(), print_long_header() and print_body() for
    screen_logger and simple_logger
  • Add more comments
  • Naming improvment

@github-actions github-actions bot added the cpp label May 23, 2024
@acelyc111 acelyc111 marked this pull request as ready for review May 24, 2024 02:01
@acelyc111 acelyc111 merged commit b39e18b into apache:master May 24, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foreverneverer foreverneverer foreverneverer approved these changes

@Smityz Smityz Smityz approved these changes

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @Smityz @foreverneverer