-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go-client): add generation thrift files of go-client #1917
chore(go-client): add generation thrift files of go-client #1917
Conversation
@lengyuexuexuan Please check the failed CIs, for |
Now that the go files have been pre-generated, the generate steps in https://github.com/apache/incubator-pegasus/blob/master/go-client/Makefile#L19 can be removed, right? Then you need to add the manual generate steps in And more, you need to add steps in .github/workflows/lint_and_test_go-client.yml to check that the pre-generated go files are the same to the ones generated manually. |
Is it possible to remove the thrift file directly in the .gitignore file, so that if the thrift file is modified, it can be uploaded directly? |
Of course, feel free to do that. |
@lengyuexuexuan Do you have some time to improve the PR ? I'm pleased to give you some help if needed. |
thanks. Today or Tomorrow I will improve this pr. |
@acelyc111 |
according to the error, you need to add these file names [1] to |
@lengyuexuexuan please check this issue as well |
done. |
apache#1881 By uploading generation thrift files, the go client can be used directly by users through "go get" without the need to compile it locally.
What problem does this PR solve?
#1881
What is changed and how does it work?
By uploading generation thrift files, the go client can be used directly by users through "go get" without the need to compile it locally.
Tests