fix: standby meta server exits abnormally with core dump after receiving the http request /meta/cluster
#1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix meta server coredump due to null pointer to balancer
empiredan
changed the title
empiredan
changed the title
/meta/cluster
acelyc111
reviewed
Dec 25, 2023
src/meta/meta_http_service.cpp
Outdated
| #ifdef DSN_MOCK_TEST | ||
| return true; | ||
| #ifdef MOCK_TEST | ||
| // Once MOCK_TEST is defined, the meta server must has been built with `./run.sh build --test`. |
There was a problem hiding this comment.
It would be better to say BUILD_TEST or MOCK_TEST is enabled, because it's possible to build by cmake directly, not using ./run.sh build.
acelyc111
approved these changes
Dec 25, 2023
GehaFearless
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1817
If meta server is built without testing(i.e.
./run.sh buildwithout--test),the macro
MOCK_TESTdedicated to test code should not be enabled,which might lead to unexpected behaviors.
On the other hand, meta server should not exit abnormally with core
dump even if it is built for testing(i.e.
./run.sh build --test). Once itfinds that balancer is not initialized by mocking, it should go through
the normal process to prevent from core dump.