Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(absl): Use the abseil in thirdparty instead of the internal copied one #1694

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Nov 24, 2023

For historical reasons, we copied some Abeil-cpp code into Pegasus to use
features like string_view, make_unique, apply and etc. The Abeil library
has been introduced into Pegasus as a thirdparty in previous patches, so
we can use it directly.
This patch has the following changes:

  • Remove the abseil files copied to Pegasus including:
    • src/utils/absl/base/internal/invoke.h
    • src/utils/absl/utility/utility.h
    • src/utils/memutil.h
    • src/utils/smart_pointers.h
    • src/utils/string_view.cpp
    • src/utils/string_view.h
    • src/utils/test/memutil_test.cpp
    • src/utils/test/smart_pointers_test.cpp
    • src/utils/test/string_view_test.cpp
  • Update license related files(.licenserc.yaml and LICENSE)
  • Use std::make_unique explicitly.
  • Add a function to_string_view(), then dsn::blob is possible to
    transfer to absl::string_view.

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol It was the old time practice to use abseil. I recalled that abseil would introduce some compiler errors at the time I tried to use it. Good to hear that you decided to fully integrate it.

@acelyc111 acelyc111 merged commit 79cd226 into apache:master Nov 27, 2023
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants