Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): Improve the project CMake #1687

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Nov 21, 2023

This patch includes these changes:

  • Move cmake_minimum_required to the top of CMakeLists.txt files.
  • Do not pass useless cmake options when build thirdparties.
  • Generate a make parallel option to speed up building thirdparty libraries.
  • Add DOWNLOAD_EXTRACT_TIMESTAMP and DOWNLOAD_NO_PROGRESS when build thirdparties
    (See https://cmake.org/cmake/help/latest/module/ExternalProject.html).
  • Remove the useless gflags thirdparty library.
  • Add a patch from offcial repository to build rocksdb, so it's possible to build
    thirdparty directly in thirdparty diretory.

@acelyc111 acelyc111 marked this pull request as ready for review November 22, 2023 02:16
@acelyc111 acelyc111 changed the title refactor(build): Improve project build refactor(build): Improve the CMakeLists.txt files Nov 22, 2023
@acelyc111 acelyc111 changed the title refactor(build): Improve the CMakeLists.txt files refactor(build): Improve the project CMake Nov 22, 2023
@acelyc111 acelyc111 merged commit b01a884 into apache:master Nov 22, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants