Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(filesystem): refactor file_utils unit tests #1634

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor(filesystem): refactor file_utils unit tests #1634

merged 1 commit into from
Oct 12, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Oct 11, 2023 •
edited
Loading

#887

  • Remove the useless return value of get_normalized_path()
  • Simplify the code of file_utils.cpp

@github-actions github-actions bot added the cpp label Oct 11, 2023
@acelyc111 acelyc111 force-pushed the refactor_file_utils branch 2 times, most recently from 2ba1edb to 7b58ac2 Compare October 11, 2023 07:46
@acelyc111 acelyc111 marked this pull request as ready for review October 11, 2023 07:47
@acelyc111 acelyc111 force-pushed the refactor_file_utils branch from 7b58ac2 to ee535df Compare October 12, 2023 02:54
@acelyc111 acelyc111 requested review from levy5307 and Smityz October 12, 2023 03:02
@acelyc111 acelyc111 merged commit ed3d31e into apache:master Oct 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz approved these changes

@empiredan empiredan Awaiting requested review from empiredan

@GehaFearless GehaFearless Awaiting requested review from GehaFearless

@levy5307 levy5307 Awaiting requested review from levy5307

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @levy5307 @Smityz