Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix build failure of rocksdb when PORTABLE=0 #1607

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix(docker): fix build failure of rocksdb when PORTABLE=0 #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7295a3
fix(docker): fix build failure of ROCKSDB_PORTABLE=0
acelyc111 Sep 14, 2023
a7be5a7
thirdparties-src
acelyc111 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/thirdparties-bin/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ COPY --from=builder /root/thirdparties-src.zip /root/thirdparties-src.zip

ARG GITHUB_BRANCH=master
ARG GITHUB_REPOSITORY_URL=https://github.com/apache/incubator-pegasus.git
ARG ROCKSDB_PORTABLE=0
ARG ROCKSDB_PORTABLE=native
ARG USE_JEMALLOC=OFF
ARG HADOOP_BIN_PATH
ARG ZOOKEEPER_BIN_PATH
Expand Down
3 changes: 2 additions & 1 deletion docker/thirdparties-src/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ ARG GITHUB_BRANCH=master
ARG GITHUB_REPOSITORY_URL=https://github.com/apache/incubator-pegasus.git
RUN git clone --depth=1 --branch=${GITHUB_BRANCH} ${GITHUB_REPOSITORY_URL}

ARG ROCKSDB_PORTABLE=native
RUN cd incubator-pegasus/thirdparty \
&& mkdir -p build \
&& cmake -DCMAKE_BUILD_TYPE=Release -B build/ . \
&& cmake -DCMAKE_BUILD_TYPE=Release -DROCKSDB_PORTABLE=${ROCKSDB_PORTABLE} -B build/ . \
&& cmake --build build/ -j $(($(nproc)/2+1))

RUN cd incubator-pegasus/thirdparty \
Expand Down
Loading