feat(build): make C++17 as required #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::random_shuffle has to be replaced by std::shuffle, because std::random_shuffle has been removed in C++17.
acelyc111
force-pushed
the
support_cpp17
branch
from
88b3da6 to
8870e93
Compare
acelyc111
force-pushed
the
support_cpp17
branch
from
323c3a0 to
2da6b0b
Compare
levy5307
approved these changes
Sep 13, 2023
Smityz
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1602
This patch adjust the build to start supporting and requiring C++17
(therefore GCC 7+).
std::random_shufflehas to be replaced bystd::shuffle, becausethe former has been removed since C++17.